wasphin commented on code in PR #2196:
URL: https://github.com/apache/brpc/pull/2196#discussion_r1164798109
##########
src/butil/containers/flat_map.h:
##########
@@ -416,7 +416,7 @@ struct DefaultHasher<std::string> {
std::size_t operator()(const butil::StringPiece& s) const {
std::size_t result = 0;
for (butil::StringPiece::const_iterator
- i = s.begin(); i != s.end(); ++i) {
+ i = s.begin(); i != s.end(); ++i) {
Review Comment:
> 这里并不是一个多余的空格
而是上一个换行导致的，你可以理解为如果418和419在一行的话，const_iterator和i中间必须要有一个空格，所以这里没有必要做修改。
这个我理解不应该这样的逻辑，不能因为在同一行有空格换行后就得保留，这样也比较奇怪，我还没见过类似的风格，本身换行后也有自己的缩进了。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
