Huixxi commented on code in PR #2177:
URL: https://github.com/apache/brpc/pull/2177#discussion_r1168434516
##########
src/brpc/controller.cpp:
##########
@@ -749,9 +780,8 @@ void Controller::Call::OnComplete(
// "single" streams are often maintained in a separate SocketMap and
// different from the main socket as well.
if (c->_stream_creator != NULL &&
- does_error_affect_main_socket(error_code) &&
(sending_sock == NULL || sending_sock->id() != peer_id)) {
- Socket::SetFailed(peer_id);
+ maybe_block_server(error_code, c, c->_lb.get(), peer_id);
}
break;
case CONNECTION_TYPE_POOLED:
Review Comment:
没有 但是does_error_affect_main_socket这个逻辑会影响到pooled类型的连接
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
