wwbmmm commented on code in PR #2231: URL: https://github.com/apache/brpc/pull/2231#discussion_r1186613106
########## src/brpc/server.cpp: ########## @@ -109,6 +109,8 @@ butil::static_atomic<int> g_running_server_count = BUTIL_STATIC_ATOMIC_INIT(0); // Following services may have security issues and are disabled by default. DEFINE_bool(enable_dir_service, false, "Enable /dir"); DEFINE_bool(enable_threads_service, false, "Enable /threads"); +DEFINE_bool(force_ssl_for_main_port, false, "Force ssl for all connections of main port"); Review Comment: 这个开关是否可以放在ServerOptions里呢，这样更灵活 ########## src/brpc/server.cpp: ########## @@ -109,6 +109,8 @@ butil::static_atomic<int> g_running_server_count = BUTIL_STATIC_ATOMIC_INIT(0); // Following services may have security issues and are disabled by default. DEFINE_bool(enable_dir_service, false, "Enable /dir"); DEFINE_bool(enable_threads_service, false, "Enable /threads"); +DEFINE_bool(force_ssl_for_main_port, false, "Force ssl for all connections of main port"); +DEFINE_bool(force_ssl_for_internal_port, false, "Force ssl for all connections of internal port"); Review Comment: 这个有必要提供吗。是不是都是false就好了。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
