chenBright commented on PR #2225: URL: https://github.com/apache/brpc/pull/2225#issuecomment-1549901819
@wwbmmm ```c++ template <typename T, typename TLS = Void, typename AllowSuspendBthread = false> class DoublyBufferedData; ``` 加bool模板参数的话，有一个问题：当AllowSuspendBthread=true（允许查询逻辑中挂起bthread）的时候，TLS 即使不为Void，DoublyBufferedData也是不支持自定义tls数据的。这样的实现好像不太友好，用户可能会比较迷惑为啥TLS没有生效吧。 或者加个`static_assert(!(AllowSuspendBthread && TLS != Void));`，在编译器发现这个问题，不支持这种用法？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
