serverglen commented on code in PR #2215: URL: https://github.com/apache/brpc/pull/2215#discussion_r1202585354
########## src/brpc/usercode_thread_pool.h: ########## @@ -0,0 +1,143 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor license agreements. See the NOTICE file +// distributed with this work for additional information +// regarding copyright ownership. The ASF licenses this file +// to you under the Apache License, Version 2.0 (the +// "License"); you may not use this file except in compliance +// with the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, +// software distributed under the License is distributed on an +// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +// KIND, either express or implied. See the License for the +// specific language governing permissions and limitations +// under the License. + +#ifndef BRPC_USERCODE_THREAD_POOL_H +#define BRPC_USERCODE_THREAD_POOL_H + +#include <deque> +#include <mutex> +#include <functional> +#include <thread> +#include <condition_variable> +#include <gflags/gflags_declare.h> +#include "butil/atomicops.h" +#include "bvar/bvar.h" +#include "bthread/task_meta.h" +#include "butil/containers/case_ignored_flat_map.h" // [CaseIgnored]FlatMap + +namespace brpc { +// Store pending user code. +struct UserCodeTask { + void (*fn)(void*); + void* arg; + void* assigned_data; +}; + +class UserCodeThreadAssignPolicy { +public: + UserCodeThreadAssignPolicy() {} + virtual ~UserCodeThreadAssignPolicy() {} + virtual size_t Index(void* arg, size_t range) = 0; + +private: + DISALLOW_COPY_AND_ASSIGN(UserCodeThreadAssignPolicy); +}; + +class UserCodeThreadRandomAssignPolicy : public UserCodeThreadAssignPolicy { Review Comment: 是不是加一个 const UserCodeThreadAssignPolicy* DefaultUserCodeThreadAssignPolicy() 函数 稍微好点？类似 DefaultRetryPolicy(); -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
