chenBright commented on code in PR #2273:
URL: https://github.com/apache/brpc/pull/2273#discussion_r1226911153
##########
test/brpc_channel_unittest.cpp:
##########
@@ -1810,6 +1811,73 @@ class ChannelTest : public ::testing::Test{
StopAndJoin();
}
+ struct TetsRetryBackoff {
Review Comment:
done
##########
src/brpc/controller.cpp:
##########
@@ -1013,6 +1020,18 @@ void Controller::IssueRPC(int64_t start_realtime_us) {
return;
}
+ bthread::TaskGroup* g = bthread::tls_task_group;
+ // Only bthread task can retry with backoff.
+ if (g && !g->is_current_pthread_task() && _retry_backoff &&
_current_call.nretry > 0) {
+ int64_t remaining_rpc_time_us = _deadline_us -
butil::gettimeofday_us();
Review Comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
