wwbmmm commented on code in PR #2273:
URL: https://github.com/apache/brpc/pull/2273#discussion_r1241070789
##########
src/brpc/controller.cpp:
##########
@@ -625,33 +630,49 @@ void Controller::OnVersionedRPCReturned(const
CompletionInfo& info,
++_current_call.nretry;
add_flag(FLAGS_BACKUP_REQUEST);
return IssueRPC(butil::gettimeofday_us());
- } else if (_retry_policy ? _retry_policy->DoRetry(this)
- : DefaultRetryPolicy()->DoRetry(this)) {
- // The error must come from _current_call because:
- // * we intercepted error from _unfinished_call in
OnVersionedRPCReturned
- // * ERPCTIMEDOUT/ECANCELED are not retrying error by default.
- CHECK_EQ(current_id(), info.id) << "error_code=" << _error_code;
- if (!SingleServer()) {
- if (_accessed == NULL) {
- _accessed = ExcludedServers::Create(
- std::min(_max_retry, RETRY_AVOIDANCE));
- if (NULL == _accessed) {
- SetFailed(ENOMEM, "Fail to create ExcludedServers");
- goto END_OF_RPC;
+ } else {
+ auto retry_policy = _retry_policy ? _retry_policy :
DefaultRetryPolicy();
+ if (retry_policy && retry_policy->DoRetry(this)) {
Review Comment:
按原来的代码逻辑，无须判断if (retry_policy)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
