Tuvie commented on code in PR #2326: URL: https://github.com/apache/brpc/pull/2326#discussion_r1271664533
########## src/brpc/rdma/rdma_endpoint.cpp: ########## @@ -71,20 +71,20 @@ static const size_t RESERVED_WR_NUM = 3; // message length (2B) // hello version (2B) // impl version (2B): 0 means should use tcp -// block size (2B) +// block size (4B) // sq size (2B) // rq size (2B) // GID (16B) // QP number (4B) static const char* MAGIC_STR = "RDMA"; static const size_t MAGIC_STR_LEN = 4; -static const size_t HELLO_MSG_LEN_MIN = 38; +static const size_t HELLO_MSG_LEN_MIN = 40; static const size_t HELLO_MSG_LEN_MAX = 4096; static const size_t ACK_MSG_LEN = 4; -static uint16_t g_rdma_hello_msg_len = 38; // In Byte +static uint16_t g_rdma_hello_msg_len = 40; // In Byte static uint16_t g_rdma_hello_version = 1; Review Comment: Since we modify the hello message format, we should change the hello version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
