pavel2003 opened a new issue, #2327:
URL: https://github.com/apache/brpc/issues/2327
**Describe the bug (描述bug)**
1310 void Controller::HandleStreamConnection(Socket *host_socket) {
1311 if (_request_stream == INVALID_STREAM_ID) {
1312 CHECK(!has_remote_stream());
1313 return;
1314 }
1315 SocketUniquePtr ptr;
1316 if (!FailedInline()) {
1317 if (Socket::Address(_request_stream, &ptr) != 0) {
1318 if (!FailedInline()) {
1319 SetFailed(EREQUEST, "Request stream=%" PRIu64 " was
closed before responded",
1320 _request_stream);
由于stream的数据是异步交给queue处理的,所以close的frame如果先处理的话,这里是会走到SetFailed的
stub.XXX(&cntl)
if (cntl.Failed())
如果业务这么用的话,cntl.Failed()就会返回真,这个错误可以忽略吗?
从日志看的话,说明作者应该知道这种情况,所以想问下对于使用者来说,cntl.Failed()是否可以不用管,这种情况下继续走下去会有其他隐患吗
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]