Huixxi commented on code in PR #2324:
URL: https://github.com/apache/brpc/pull/2324#discussion_r1273042189
##########
src/butil/thread_local.h:
##########
@@ -46,10 +46,10 @@
var_name = v;
\
}
-#if defined(__clang__)
-// Clang compiler is incorrectly caching the address of thread_local variables
-// across a suspend-point. The following macros used to disable the volatile
-// thread local access optimization.
+#if (defined (__aarch64__) && defined (__GNUC__)) || defined(__clang__)
+// GNU compiler under aarch and Clang compiler is incorrectly caching the
Review Comment:
注释可能需要改成GNU compiler under aarch and clang is ....
##########
src/butil/thread_local.h:
##########
@@ -46,10 +46,10 @@
var_name = v;
\
}
-#if defined(__clang__)
-// Clang compiler is incorrectly caching the address of thread_local variables
-// across a suspend-point. The following macros used to disable the volatile
-// thread local access optimization.
+#if (defined (__aarch64__) && defined (__GNUC__)) || defined(__clang__)
+// GNU compiler under aarch and Clang compiler is incorrectly caching the
Review Comment:
注释可能需要改成GNU compiler under aarch and clang is ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
