qqwangxiaow commented on code in PR #2340:
URL: https://github.com/apache/brpc/pull/2340#discussion_r1283975804


##########
src/brpc/redis_reply.h:
##########
@@ -318,7 +318,8 @@ inline void RedisReply::Swap(RedisReply& other) {
     std::swap(_length, other._length);
     std::swap(_data.padding[0], other._data.padding[0]);

Review Comment:
   @chenBright _arena指向的内容 在RedisResponse里面已经交换了 , reply只要保证是指向类中的_arean就行



##########
src/brpc/redis_reply.h:
##########
@@ -318,7 +318,8 @@ inline void RedisReply::Swap(RedisReply& other) {
     std::swap(_length, other._length);
     std::swap(_data.padding[0], other._data.padding[0]);

Review Comment:
   @chenBright _arena指向的内容 在RedisResponse里面已经交换了 , reply只要保证是指向类中的_arean就行



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to