wwbmmm commented on code in PR #2367:
URL: https://github.com/apache/brpc/pull/2367#discussion_r1318293294
##########
src/brpc/builtin/connections_service.cpp:
##########
@@ -161,7 +161,8 @@ void ConnectionsService::PrintConnections(
if (ret < 0) {
continue;
} else if (ret > 0) {
- if (ptr->_health_check_interval_s <= 0) {
+ if (ptr->_health_check_interval_s <= 0 ||
Review Comment:
关于health_check_interval和_is_hc_related_ref_held的判断是不是可以封装成一个方法，比如HCEnabled，避免实现细节暴露到太多地方
##########
src/brpc/builtin/connections_service.cpp:
##########
@@ -161,7 +161,8 @@ void ConnectionsService::PrintConnections(
if (ret < 0) {
continue;
} else if (ret > 0) {
- if (ptr->_health_check_interval_s <= 0) {
+ if (ptr->_health_check_interval_s <= 0 ||
Review Comment:
关于health_check_interval和_is_hc_related_ref_held的判断是不是可以封装成一个方法，比如HCEnabled，避免实现细节暴露到太多地方
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
