wwbmmm commented on code in PR #2387:
URL: https://github.com/apache/brpc/pull/2387#discussion_r1330049003
##########
test/brpc_http_rpc_protocol_unittest.cpp:
##########
@@ -1544,7 +1544,7 @@ TEST_F(HttpTest, http2_header_after_data) {
ASSERT_EQ(res_header.content_type(), "application/proto");
// Check overlapped header is overwritten by the latter.
const std::string* user_defined1 = res_header.GetHeader("user-defined1");
- ASSERT_EQ(*user_defined1, "overwrite-a");
+ ASSERT_EQ(*user_defined1, "a,overwrite-a");
Review Comment:
The original test case was written as "overwrite-a", was it expected to be
overwritten? Changing the behavior here may not conform to the previous design.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
