ehds commented on code in PR #2421:
URL: https://github.com/apache/brpc/pull/2421#discussion_r1368083110
##########
CMakeLists.txt:
##########
@@ -148,8 +148,8 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# segmentation fault in libcontext
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-gcse")
endif()
- if(NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 7.0))
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-aligned-new")
+ if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0)
Review Comment:
我看 CMakeLists 也有判断 Clang 的逻辑，这里是否也需要对 Clang 编译器生效？
##########
CMakeLists.txt:
##########
@@ -148,8 +148,8 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")
# segmentation fault in libcontext
set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fno-gcse")
endif()
- if(NOT (CMAKE_CXX_COMPILER_VERSION VERSION_LESS 7.0))
- set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-aligned-new")
+ if(CMAKE_CXX_COMPILER_VERSION VERSION_GREATER 7.0)
Review Comment:
我看 CMakeLists 也有判断 Clang 的逻辑，这里是否也需要对 Clang 编译器生效？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
