This is an automated email from the ASF dual-hosted git repository.
wwbmmm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new a3becd3a Reserve at least one idle socket (#2390)
a3becd3a is described below
commit a3becd3ab0e8b72a20f98332dba90786a147dcbd
Author: Bright Chen <chenguangmin...@foxmail.com>
AuthorDate: Wed Oct 25 15:03:42 2023 +0800
Reserve at least one idle socket (#2390)
---
src/brpc/socket_map.cpp | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/src/brpc/socket_map.cpp b/src/brpc/socket_map.cpp
index 50b3d36a..774bf5a7 100644
--- a/src/brpc/socket_map.cpp
+++ b/src/brpc/socket_map.cpp
@@ -50,6 +50,9 @@ DEFINE_bool(show_socketmap_in_vars, false,
"[DEBUG] Describe SocketMaps in /vars");
BRPC_VALIDATE_GFLAG(show_socketmap_in_vars, PassValidate);
+DEFINE_bool(reserve_one_idle_socket, false,
+ "Reserve one idle socket for pooled connections when
idle_timeout_second > 0");
+
static pthread_once_t g_socket_map_init = PTHREAD_ONCE_INIT;
static butil::static_atomic<SocketMap*> g_socket_map =
BUTIL_STATIC_ATOMIC_INIT(NULL);
@@ -360,11 +363,12 @@ void SocketMap::WatchConnections() {
if (idle_seconds > 0) {
// Check idle pooled connections
List(&main_sockets);
- for (size_t i = 0; i < main_sockets.size(); ++i) {
+ for (auto main_socket : main_sockets) {
SocketUniquePtr s;
- if (Socket::Address(main_sockets[i], &s) == 0) {
+ if (Socket::Address(main_socket, &s) == 0) {
s->ListPooledSockets(&pooled_sockets);
- for (size_t i = 0; i < pooled_sockets.size(); ++i) {
+ for (size_t i = FLAGS_reserve_one_idle_socket ? 1 : 0;
+ i < pooled_sockets.size(); ++i) {
SocketUniquePtr s2;
if (Socket::Address(pooled_sockets[i], &s2) == 0) {
s2->ReleaseReferenceIfIdle(idle_seconds);
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
