Divyansh200102 commented on code in PR #2462:
URL: https://github.com/apache/brpc/pull/2462#discussion_r1432216337
##########
src/brpc/event_dispatcher.h:
##########
@@ -64,12 +64,12 @@ friend class rdma::RdmaEndpoint;
// be used instead of EPOLL_CTL_ADD. When event arrives,
// `Socket::HandleEpollOut' will be called with `socket_id'
// Returns 0 on success, -1 otherwise and errno is set
- int AddEpollOut(SocketId socket_id, int fd, bool pollin);
+ int RegisterEvent(SocketId socket_id, int fd, bool pollin);
// Remove EPOLLOUT event on `fd'. If `pollin' is true, EPOLLIN event
// will be kept and EPOLL_CTL_MOD will be used instead of EPOLL_CTL_DEL
// Returns 0 on success, -1 otherwise and errno is set
- int RemoveEpollOut(SocketId socket_id, int fd, bool pollin);
+ int DeregisterEvent(SocketId socket_id, int fd, bool pollin);
Review Comment:
Okay
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
