wasphin commented on code in PR #2546: URL: https://github.com/apache/brpc/pull/2546#discussion_r1501831395
########## CMakeLists.txt: ########## @@ -156,6 +154,50 @@ if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU") endif() find_package(Protobuf REQUIRED) +if(Protobuf_VERSION GREATER_EQUAL 4.22) + # required by absl + set(CMAKE_CXX_STANDARD 17) + + find_package(absl REQUIRED CONFIG) Review Comment: 基于 CONFIG 方式查找 protobuf 可以推导依赖, 但不是所有 protobuf 都提供, 同时 protoc 相关的任务也需要改 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
