chenBright commented on code in PR #2560:
URL: https://github.com/apache/brpc/pull/2560#discussion_r1536847585
##########
src/brpc/socket_inl.h:
##########
@@ -176,17 +119,25 @@ inline void Socket::ReAddress(SocketUniquePtr* ptr) {
}
inline int Socket::AddressFailedAsWell(SocketId id, SocketUniquePtr* ptr) {
+ return AddressImpl(id, true, ptr);
+}
+
+inline int Socket::AddressImpl(SocketId id,
Review Comment:
看了一下，在VersionedRefWithId实现revive，Socket实现health check，这样应该可以。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
