yanglimingcn commented on code in PR #2610: URL: https://github.com/apache/brpc/pull/2610#discussion_r1580653847
########## src/brpc/span.cpp: ########## @@ -506,6 +509,12 @@ inline uint64_t ToLittleEndian(const uint32_t* buf) { } SpanDB* SpanDB::Open() { + // Remove old rpcz directory even if crash occurs. + if (!FLAGS_rpcz_keep_span_db) { + std::string cmd = butil::string_printf("rm -rf %s", FLAGS_rpcz_database_dir.c_str()); Review Comment: 如果只删除id.db和time.db,目录下会遗留很多类似这样20240205.083927.20680的空目录。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org