chenBright commented on code in PR #2629:
URL: https://github.com/apache/brpc/pull/2629#discussion_r1591749339
##########
src/brpc/controller.h:
##########
@@ -305,7 +305,9 @@ friend void policy::ProcessThriftRequest(InputMessageBase*);
// Get/own SampledRequest for sending dumped requests.
// Deleted along with controller.
void reset_sampled_request(SampledRequest* req);
- const SampledRequest* sampled_request() { return _sampled_request; }
+ const SampledRequest* sampled_request() const { return _sampled_request; }
Review Comment:
1. 也不太合适，SampledRequest不仅支持baidu-std协议，还支持其他协议。
2. 改名字是不是对兼容性不友好？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
