MJY-HUST commented on code in PR #2645:
URL: https://github.com/apache/brpc/pull/2645#discussion_r1635186376
##########
src/bthread/key.cpp:
##########
@@ -226,14 +270,16 @@ void return_keytable(bthread_keytable_pool_t* pool,
KeyTable* kt) {
delete kt;
return;
}
- std::unique_lock<pthread_mutex_t> mu(pool->mutex);
+ pthread_rwlock_rdlock(&pool->rwlock);
if (pool->destroyed) {
- mu.unlock();
+ pthread_rwlock_unlock(&pool->rwlock);
delete kt;
return;
}
- kt->next = (KeyTable*)pool->free_keytables;
- pool->free_keytables = kt;
+ auto list = (butil::ThreadLocal<bthread::KeyTableList>*)pool->list;
Review Comment:
是不会返回给free_keytables了。free_keytables的大小是根据server.option的reserved_thread_local_data变量设置的，默认为0。
不过这里的线程指的应该只是一个bthread_keytable_pool_t pool所对应的server的brpc_worker
threads，而不是普通的pthread。
所以相比使用单链表管理，如果brpc_worker
thread是公平调度的话，内部的butil::ThreadLocal维护的链表长度应该是比使用一个单链表来说要短，但是性能会更好，因为同样存在回收机制，内存不会多太多。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
