AnDiXL opened a new pull request, #2710: URL: https://github.com/apache/brpc/pull/2710
…otocol ### What problem does this PR solve? Issue Number: resolve #2408 Problem Summary: ### What is changed and the side effects? 原本 tools/wireshark_baidu_std.lua 的实现存在两个问题： 1. 由于原本传入的解析长度是body_size - meta_size，这会导致解析时不止解析了BRPC Message，还会把Attachment也一同解析，出现一些令人困惑的解析结果； 2. 原本的实现方式只支持解析包含单个RPC请求/响应的报文，但实际同一报文中是可能包含多个RPC请求/响应的。 Changed: 修复 #2408 引入的wireshark dissector无法解析包含多个baidu_std protocol请求的报文的问题。 Side effects: - Performance effects(性能影响):无 - Breaking backward compatibility(向后兼容性): yes --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](../../master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
