GreateCode commented on code in PR #2734:
URL: https://github.com/apache/brpc/pull/2734#discussion_r1712584249
##########
src/brpc/controller.cpp:
##########
@@ -344,6 +345,11 @@ void Controller::set_backup_request_ms(int64_t timeout_ms)
{
}
}
+int64_t Controller::backup_request_ms() const {
+ return NULL != _backup_request_policy ?
+ _backup_request_policy->GetBackupRequestMs() : _backup_request_ms;
+}
Review Comment:
设置policy后，Controller::backup_request_ms返回的总是policy里的backup_request_ms，而policy又只有channel才能设置，意味着backup_request_ms是channel全局的，导致cntl（请求粒度）设置的backup_request_ms不生效了。
这对channel的多个接口场景来说不合理。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
