chenBright commented on code in PR #2751:
URL: https://github.com/apache/brpc/pull/2751#discussion_r1740638942
##########
docs/cn/server.md:
##########
@@ -1027,20 +1027,31 @@ Server默认使用`DefaultRpcPBMessageFactory`。它是一个简单的工厂类
class RpcPBMessages {
public:
virtual ~RpcPBMessages() = default;
+ // Get protobuf request message.
virtual google::protobuf::Message* Request() = 0;
+ // Get protobuf response message.
virtual google::protobuf::Message* Response() = 0;
};
// Factory to manage `RpcPBMessages'.
class RpcPBMessageFactory {
public:
virtual ~RpcPBMessageFactory() = default;
+
+ // Get `RpcPBMessages' according to `service' and `method'.
+ // Common practice to create protobuf message:
+ // service.GetRequestPrototype(&method).New() -> request;
+ // service.GetRequestPrototype(&method).New() -> response.
virtual RpcPBMessages* Get(const ::google::protobuf::Service& service,
const ::google::protobuf::MethodDescriptor&
method) = 0;
- virtual void Return(RpcPBMessages* protobuf_message) = 0;
+ // Return `RpcPBMessages' to factory.
+ virtual void Return(RpcPBMessages* messages) = 0;
};
```
+### Protobuf arena
+
Review Comment:
是的，还没写文档。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
