chenBright commented on code in PR #2734:
URL: https://github.com/apache/brpc/pull/2734#discussion_r1769524043
##########
src/brpc/controller.cpp:
##########
@@ -1259,6 +1278,11 @@ int Controller::HandleSocketFailed(bthread_id_t id,
void* data, int error_code,
cntl->timeout_ms(),
butil::endpoint2str(cntl->remote_side()).c_str());
} else if (error_code == EBACKUPREQUEST) {
+ BackupRequestPolicy* policy = cntl->_backup_request_policy;
Review Comment:
当时想着就不需要SetFailed和起协程了。但是现在发现BackupRequestPolicy同样有#2419
的问题，所以还是得改成在OnVersionedRPCReturned里面。
##########
src/brpc/controller.cpp:
##########
@@ -1259,6 +1278,11 @@ int Controller::HandleSocketFailed(bthread_id_t id,
void* data, int error_code,
cntl->timeout_ms(),
butil::endpoint2str(cntl->remote_side()).c_str());
} else if (error_code == EBACKUPREQUEST) {
+ BackupRequestPolicy* policy = cntl->_backup_request_policy;
Review Comment:
当时想着就不需要SetFailed和起协程了。但是现在发现BackupRequestPolicy同样有#2419
的问题，所以还是得改成在OnVersionedRPCReturned里面。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
