chenBright commented on code in PR #2782:
URL: https://github.com/apache/brpc/pull/2782#discussion_r1817716487
##########
src/brpc/esp_message.h:
##########
@@ -18,64 +18,32 @@
#ifndef BRPC_ESP_MESSAGE_H
#define BRPC_ESP_MESSAGE_H
-#include <string>
-
-#include <google/protobuf/message.h>
-#include <google/protobuf/generated_message_reflection.h> //
dynamic_cast_if_available
-#include <google/protobuf/reflection_ops.h> // ReflectionOps::Merge
-
#include "brpc/esp_head.h"
-#include "butil/iobuf.h"
-#include "brpc/proto_base.pb.h"
-#include "brpc/pb_compat.h"
+#include "brpc/message_helper.h"
+#include "butil/iobuf.h"
namespace brpc {
-class EspMessage : public ::google::protobuf::Message {
+class EspMessage : public MessageHelper<EspMessage>::BaseType {
Review Comment:
MessageHelper有什么作用呢？目前来说，是不是直接继承NonreflectableMessage<T>就可以了吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
