yanglimingcn commented on code in PR #2842:
URL: https://github.com/apache/brpc/pull/2842#discussion_r1909958329
##########
src/brpc/parallel_channel.cpp:
##########
@@ -655,9 +665,21 @@ void ParallelChannel::CallMethod(
fail_limit = ndone;
}
}
-
- d = ParallelChannelDone::Create(fail_limit, ndone, aps, nchan,
- cntl, done);
+
+ // `success_limit' is only valid when `fail_limit' is not set.
Review Comment:
没看出来success_limit为啥没起作用，在fail_limit==-1的时候吗？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
