chenBright commented on code in PR #2872:
URL: https://github.com/apache/brpc/pull/2872#discussion_r1913256498
##########
src/brpc/server.cpp:
##########
@@ -813,12 +813,24 @@ int Server::StartInternal(const butil::EndPoint& endpoint,
}
return -1;
}
- if (opt) {
+
+ if (&_options == opt) {
+ // do nothing
+ } else if (opt) {
+ if (_options.rpc_pb_message_factory != opt->rpc_pb_message_factory) {
+ delete _options.rpc_pb_message_factory;
+ _options.rpc_pb_message_factory = NULL;
+ }
Review Comment:
The same problem exists with other pointers in ServerOptions (redis_service,
http_master_service, etc.). Maybe a function can be added to handle them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
