yanglimingcn commented on code in PR #2867:
URL: https://github.com/apache/brpc/pull/2867#discussion_r1914140579
##########
src/brpc/socket_inl.h:
##########
@@ -23,21 +23,6 @@
namespace brpc {
-inline SocketOptions::SocketOptions()
- : fd(-1)
- , connect_on_create(false)
Review Comment:
这里为啥把构造函数去掉了，选择在类中原地赋值呢？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
