jenrryyou commented on code in PR #2889:
URL: https://github.com/apache/brpc/pull/2889#discussion_r1957544064
##########
src/brpc/stream.cpp:
##########
@@ -36,6 +36,9 @@ namespace brpc {
DECLARE_bool(usercode_in_pthread);
DECLARE_int64(socket_max_streams_unconsumed_bytes);
+DEFINE_uint64(stream_write_max_segment_size, 512 * 1024 * 1024,
Review Comment:
嗯，可以调小，不过没有想到一个合适的值，看你建议。当时设置默认值512MB是想让用户手动设置下Gflags来开启这个能力，否则就用一个比较大的值，等内部生产收集到比较多的最佳实践再调整这个默认值。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
