SamYuan1990 opened a new pull request, #2911: URL: https://github.com/apache/brpc/pull/2911
### What problem does this PR solve? Issue Number: n/A Problem Summary: A nit fix using const instead of static new, I am not C++ expert, but it seems we just have `static std::string*` with a fix value in previous implications of this PR. I suppose: - static string with a fix value equals with const, as 1st commit. - After 1st commit of this PR, I notice that if a function just returns a const string, in fact, we can use a const string replace. as I am not C++ expert, I used another 3 commits to fix the compile issue. ### What is changed and the side effects? Changed: Side effects: - Performance effects(性能影响): I suppose those implements either previous impl for this PR or changes in this PR moves to compiler optimization. I searched and learned through www, I suppose there only difference between the memory location for static(previous) and const(this PR), but compiler optimization is out of my knowledge, as previous adding additional function stack.... - Breaking backward compatibility(向后兼容性): --- ### Check List: - Please make sure your changes are compilable(请确保你的更改可以通过编译). - When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试). - Please follow [Contributor Covenant Code of Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).(请遵循贡献者准则). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
