wwbmmm commented on code in PR #2942:
URL: https://github.com/apache/brpc/pull/2942#discussion_r2032253068
##########
src/butil/iobuf.cpp:
##########
@@ -1371,6 +1371,41 @@ IOBuf::Area IOBuf::reserve(size_t count) {
return result;
}
+IOBuf::Area IOBuf::reserve_aligned(size_t n, size_t alignment) {
+ size_t count = (n + alignment - 1) & ~(alignment - 1);
+ IOBuf::Area result = INVALID_AREA;
+ size_t total_nc = 0;
+ while (total_nc < count) { // excluded count == 0
+ IOBuf::Block* b = iobuf::share_tls_block();
+ CHECK(alignment <= b->cap)
+ << "alignment must not greater than block capacity";
+ if (BAIDU_UNLIKELY(!b)) {
+ return INVALID_AREA;
+ }
+ const size_t remainder =
+ reinterpret_cast<uintptr_t>(b->data + b->size) % alignment;
+ const size_t align_offset =
+ (remainder != 0) ? alignment - remainder : 0;
+ if (b->left_space() - align_offset < alignment) {
+ b->size = b->cap;
+ continue;
Review Comment:
alignment不是动态传进来的参数吗？block大小是事先确定的，应该只能在alignment传参的时候检查alignment和block大小的关系是否符合条件吧？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
