zhengJade commented on code in PR #2819:
URL: https://github.com/apache/brpc/pull/2819#discussion_r2041500195
##########
src/brpc/event_dispatcher_epoll.cpp:
##########
@@ -70,7 +70,8 @@ int EventDispatcher::Start(const bthread_attr_t*
consumer_thread_attr) {
// Set _thread_attr before creating epoll thread to make sure
// everyting seems sane to the thread.
_thread_attr = consumer_thread_attr ?
- *consumer_thread_attr : BTHREAD_ATTR_NORMAL;
+ *consumer_thread_attr : _thread_attr;
Review Comment:
> 默认的attr就是EPOLL，这里是不是可以改成这样更直观一些：
>
> ```
> if (consumer_thread_attr) {
> _thread_attr = *consumer_thread_attr | BTHREAD_GLOBAL_PRIORITY
> }
> ```
我仔细看了下，这里可以这样改的
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
