Copilot commented on code in PR #2965:
URL: https://github.com/apache/brpc/pull/2965#discussion_r2078899513
##########
src/brpc/rdma/block_pool.cpp:
##########
@@ -292,6 +292,12 @@ static void* AllocBlockFrom(int block_type) {
BAIDU_SCOPED_LOCK(*g_info->lock[block_type][index]);
IdleNode* node = g_info->idle_list[block_type][index];
if (!node) {
+ // runtime extend block g_buckets must equal 1
+ if (g_buckets != 1) {
+ LOG_EVERY_SECOND(ERROR) << "Fail to extend block pool runtime, "
+ "rdma_memory_pool_buckets must be 1";
Review Comment:
The error log message could be enhanced to include the current value of
g_buckets for improved diagnostics.
```suggestion
"rdma_memory_pool_buckets must be 1. "
"Current value of g_buckets: " <<
g_buckets;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
