wwbmmm commented on PR #2994: URL: https://github.com/apache/brpc/pull/2994#issuecomment-2974911704
Thank you for your contribution! I suggest to add a flag for backward compatibility: If the flag is on, add server tag for hash computing, if the flag is off, remain the original logic. Since consistent-hashing is always used in senarios that the servers are stateful, changing hashing logic may cause the request routed to new server that does not contain previous data for that request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org
