chenBright opened a new pull request, #3010:
URL: https://github.com/apache/brpc/pull/3010

   ### What problem does this PR solve?
   
   Issue Number: resolve #2998
   
   Problem Summary:
   
   When the health check is turned off, the SocketMap does not hold a reference 
to the Socket, so the Socket will be abnormally recycled when the connection is 
closed.
   
   ### What is changed and the side effects?
   
   Changed:
   
   Regardless of whether the health check is enabled, SocketMap must hold a 
reference to the socket.
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org

Reply via email to