wwbmmm commented on code in PR #3033: URL: https://github.com/apache/brpc/pull/3033#discussion_r2217788246
########## src/bthread/task_control.h: ########## @@ -103,8 +103,7 @@ friend bthread_t init_for_pthread_stack_trace(); private: typedef std::array<TaskGroup*, BTHREAD_MAX_CONCURRENCY> TaggedGroups; - static const int PARKING_LOT_NUM = 4; - typedef std::array<ParkingLot, PARKING_LOT_NUM> TaggedParkingLot; + typedef std::array<ParkingLot, BTHREAD_MAX_CONCURRENCY> TaggedParkingLot; Review Comment: Can define a new constant BTHREAD_MAX_PARKINGLOT and add validator for bthread_parking_lot_of_each_tag ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org For additional commands, e-mail: dev-h...@brpc.apache.org