live4thee commented on code in PR #3034:
URL: https://github.com/apache/brpc/pull/3034#discussion_r2241858442
##########
src/brpc/rdma/rdma_endpoint.cpp:
##########
@@ -1328,7 +1342,7 @@ static const int MAX_CQ_EVENTS = 128;
int RdmaEndpoint::GetAndAckEvents() {
int events = 0; void* context = NULL;
while (1) {
- if (IbvGetCqEvent(_resource->comp_channel, &_resource->cq, &context) <
0) {
+ if (IbvGetCqEvent(_resource->comp_channel, &_resource->cq, &context)
!= 0) {
Review Comment:
应该不需要。因为看 rdma-core 的代码，这里最终调用的就是 `read(channel->fd, ...)`, 不像其它
`ibv_post_send()` 之类直接返回一个错误码。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
