wwbmmm commented on code in PR #3061:
URL: https://github.com/apache/brpc/pull/3061#discussion_r2268703064
##########
src/brpc/parallel_channel.cpp:
##########
@@ -139,6 +139,18 @@ class ParallelChannelDone : public
google::protobuf::Closure {
new (d->sub_done(i)) SubDone;
d->sub_done(i)->cntl.ApplyClientSettings(settings);
d->sub_done(i)->cntl.allow_done_to_run_in_place();
+
+ // Propagate all HTTP headers from parent controller to
sub-controllers.
+ // This preserves application-set headers (e.g., Authorization) on
each sub-call.
Review Comment:
Does it need to check if sub-controller headers has exists key before
AppendHeader or SetHeader? Avoid overwrite existing header.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@brpc.apache.org
For additional commands, e-mail: dev-h...@brpc.apache.org
