old-bear commented on PR #3105: URL: https://github.com/apache/brpc/pull/3105#issuecomment-3326208900
> Is BIO_flush still needed? > > https://github.com/apache/brpc/blob/7229c3608f8cb98b24a0a2e7f99bc01d357d9312/src/butil/iobuf.cpp#L934-L939 No. BIO_wpending will return 0, so this code will not be reached. For clarity, I have commented out the code and left a note. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
