lh2debug opened a new pull request, #3140:
URL: https://github.com/apache/brpc/pull/3140

   ### What problem does this PR solve?
   
   Issue Number: resolve #3068 
   
   Problem Summary:
   
   Span lifecycle management defect in distributed storage system:
   
   Problem Scenario:
   - ChunkServer maintains a parent span for client WriteChunk requests
   - Two child spans are created for append_entries RPCs to followers
   - When the first follower responds, the parent span is prematurely destroyed 
along with all child spans
   - When the second follower responds, it attempts to access the already-freed 
child span, causing use-after-free
   
   Root Cause:
   a. Premature deallocation: Parent span destroyed while child spans still in 
use
   b. Dangling pointer: Response callback accesses freed span objects
   
   More details:
   
https://github.com/lh2debug/brpc/blob/master-lh2-fix-span-pdf/Optimization%20of%20RPCZ%20Span%20Lifecycle%20Management.pdf
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects: NO
   - Performance effects: NO
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to