wwbmmm commented on PR #3140: URL: https://github.com/apache/brpc/pull/3140#issuecomment-3501841280
> 4. To ensure compatibility with advanced clients who modify their protocols, using the `BRPC_ENABLE_SHARED_SPAN` macro to control the use of `Span*` or `std::weak_ptr<Span>` in the `ControllerPrivateAccessor` layer can resolve compilation issues. However, the `Span*` approach may still cause crashes in certain scenarios. > > If the implementation follows the `BRPC_ENABLE_SHARED_SPAN` macro control, could it mislead them into believing that the `Span*` approach is stable and reliable for performance analysis? We can add some notes in the document and code comment. I think that's OK. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
