wwbmmm commented on PR #3138: URL: https://github.com/apache/brpc/pull/3138#issuecomment-3519881793
> Hi @wwbmmm, I have added the unit test cases, traditional approach example and updated the documentation regarding it. Can you take a look at it? Thank you. Most look good, can you remove the `using namespace std;` in the `couchbase.h` file? This header file may be included by user, so the `using namespace std;` may cause some conflicts in user code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
