chenBright commented on code in PR #3158:
URL: https://github.com/apache/brpc/pull/3158#discussion_r2546493464
##########
src/bthread/types.h:
##########
@@ -118,6 +120,12 @@ typedef struct bthread_attr_t {
return tmp;
}
#endif // __cplusplus
+ void set_name(const char* val) {
+ if (val) {
+ strncpy(name, val, BTHREAD_NAME_MAX_LENGTH);
+ name[BTHREAD_NAME_MAX_LENGTH] = '\0';
Review Comment:
The null terminator ('\0') should be set according to the actual length of
the string being copied.
##########
src/bthread/task_group.cpp:
##########
@@ -1141,6 +1141,7 @@ void print_task(std::ostream& os, bthread_t tid, bool
enable_trace,
<< "\nattr={stack_type=" << attr.stack_type
<< " flags=" << attr.flags
<< " specified_tag=" << attr.tag
+ << " name=" << attr.name
Review Comment:
The name may be invalid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
