chenBright commented on code in PR #3158:
URL: https://github.com/apache/brpc/pull/3158#discussion_r2549277696
##########
src/bthread/types.h:
##########
@@ -118,6 +120,12 @@ typedef struct bthread_attr_t {
return tmp;
}
#endif // __cplusplus
+ void set_name(const char* val) {
+ if (val) {
+ strncpy(name, val, BTHREAD_NAME_MAX_LENGTH);
+ name[BTHREAD_NAME_MAX_LENGTH] = '\0';
Review Comment:
OK. My concern is that If 'BTHREAD_ATTR_*' is not used and the bthread name
is not set, the bthread name is random char. Other fields also have this issue,
but so far they're all working fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
