royguo commented on code in PR #3168:
URL: https://github.com/apache/brpc/pull/3168#discussion_r2608866875
##########
src/bthread/task_group.cpp:
##########
@@ -179,7 +194,17 @@ bool TaskGroup::wait_task(bthread_t* tid) {
if (steal_task(tid)) {
return true;
}
- _pl->wait(st);
+ // Instead of waiting for signal, we shall wake up if there's a user
idle task here.
Review Comment:
Not sure if it's necessary, we have only two lines of repeated code here, I
personally like to keep it this way. But of course, I can change if you have a
strong feeling that we need another function call.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
