InJunee commented on code in PR #3169: URL: https://github.com/apache/brpc/pull/3169#discussion_r2637167891
########## src/brpc/policy/baidu_rpc_protocol.cpp: ########## @@ -62,36 +66,101 @@ DEFINE_bool(baidu_std_protocol_deliver_timeout_ms, false, DECLARE_bool(pb_enum_as_number); // Notes: -// 1. 12-byte header [PRPC][body_size][meta_size] +// 1. Header format: +// - Normal format (12 bytes): [PRPC][body_size(32bit)][meta_size(32bit)] +// - Extended format (20 bytes): [PRPC][UINT32_MAX][meta_size(32bit)][body_size(64bit)] +// Extended format is used when body_size > UINT32_MAX Review Comment: Is there anything else that needs to be modified in the code? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
