wwbmmm commented on code in PR #3179:
URL: https://github.com/apache/brpc/pull/3179#discussion_r2647465986
##########
src/brpc/socket.cpp:
##########
@@ -1297,6 +1299,10 @@ int Socket::Connect(const timespec* abstime,
// We need to do async connect (to manage the timeout by ourselves).
CHECK_EQ(0, butil::make_non_blocking(sockfd));
+ if (::bind(sockfd, (struct sockaddr*)& cli_addr, addr_size) != 0) {
Review Comment:
if options.local_side is unset, you don't need to call bind here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
