altman08 commented on code in PR #3198:
URL: https://github.com/apache/brpc/pull/3198#discussion_r2706732157
##########
src/brpc/selective_channel.h:
##########
@@ -56,6 +56,11 @@ class SelectiveChannel : public ChannelBase/*non-copyable*/ {
std::string tag;
};
+ struct SubChannelOptions {
Review Comment:
ChannelHandle is not suitable to be placed inside the option because it is
returned to the user.
##########
src/brpc/selective_channel.h:
##########
@@ -69,8 +74,11 @@ class SelectiveChannel : public ChannelBase/*non-copyable*/ {
// On success, handle is set with the key for removal.
// NOTE: Different from pchan, schan can add channels at any time.
// Returns 0 on success, -1 otherwise.
- int AddChannel(ChannelBase* sub_channel, ChannelHandle* handle);
- int AddChannel(ChannelBase* sub_channel, const std::string& tag,
ChannelHandle* handle);
Review Comment:
This function was merged a few days ago but hasn't been released yet. I
think it's ok to remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
