ivanallen commented on code in PR #3199:
URL: https://github.com/apache/brpc/pull/3199#discussion_r2720680525
##########
src/brpc/acceptor.h:
##########
@@ -110,8 +111,8 @@ friend class Server;
bool _force_ssl;
std::shared_ptr<SocketSSLContext> _ssl_ctx;
- // Whether to use rdma or not
- bool _use_rdma;
+ // Choose to use a certain socket: 0 TCP, 1 RDMA
+ SocketMode socket_mode;
Review Comment:
Private field is starting prefix `_`.
```
SocketMode _socket_mode;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
